19913d85-f662-4518-a9a1-7adc1793dfd4.png){kind=small}
Channels
#announcements
- f
freiksenet
09/04/2018, 1:52 PMand then it happens - f
freiksenet
09/04/2018, 1:52 PMand you see it at read-the-docs - f
freiksenet
09/04/2018, 1:52 PM - f
freiksenet
09/04/2018, 1:52 PMyou can enable/disable branches - f
freiksenet
09/04/2018, 1:52 PMmaster is currently broken - f
freiksenet
09/04/2018, 1:52 PMbuilding there - f
freiksenet
09/04/2018, 1:52 PMbut we can have versioned docs later - f
freiksenet
09/04/2018, 1:52 PMwhich is nice - s
schrockn
09/04/2018, 1:53 PMya - s
schrockn
09/04/2018, 1:53 PMhmmm it’s not parsing the google-style docstrings - f
freiksenet
09/04/2018, 1:53 PMI don't know what's google style docstrings - f
freiksenet
09/04/2018, 1:54 PM - f
freiksenet
09/04/2018, 1:54 PMso it's possible to fix it - s
schrockn
09/04/2018, 1:55 PMya - s
schrockn
09/04/2018, 1:55 PMthat would be good - s
schrockn
09/04/2018, 1:55 PMcan you bang that out - s
schrockn
09/04/2018, 1:55 PMthe other thing that would be nice - f
freiksenet
09/04/2018, 1:55 PMshould work now - f
freiksenet
09/04/2018, 1:55 PMjust give it 5mins to build - s
schrockn
09/04/2018, 1:55 PMis a makefile command to yapf all python files - f
freiksenet
09/04/2018, 1:56 PMdo 'pip install pre-commit" - f
freiksenet
09/04/2018, 1:56 PMthen "pre-commit install" - f
freiksenet
09/04/2018, 1:57 PMthis will add pre commit hook to yapf all changed python files - s
schrockn
09/04/2018, 1:58 PMhmmmm - s
schrockn
09/04/2018, 1:58 PMi like having explicit control over when to do this type of thing - s
schrockn
09/04/2018, 1:59 PMyeah i hate this - f
freiksenet
09/04/2018, 2:00 PMalternatively we should fail all commits without yapf formatted files 😛 - f
freiksenet
09/04/2018, 2:00 PMbut then everyone will do an extra commit in PR named "fix yapf" - s
schrockn
09/04/2018, 2:02 PMthis workflow is super confuging - s
schrockn
09/04/2018, 2:02 PMconfusing