19913d85-f662-4518-a9a1-7adc1793dfd4.png){kind=small}
Channels
#announcements
- s
schrockn
09/04/2018, 2:02 PMit automatically alters the commit - s
schrockn
09/04/2018, 2:02 PM? - f
freiksenet
09/04/2018, 2:04 PMyeah - s
schrockn
09/04/2018, 2:05 PMno no no - s
schrockn
09/04/2018, 2:05 PMthis is a bad idea - s
schrockn
09/04/2018, 2:05 PMcould cause totally confusing behavior - s
schrockn
09/04/2018, 2:05 PMfuck up merges - s
schrockn
09/04/2018, 2:05 PMall sorts of things - s
schrockn
09/04/2018, 2:05 PMthe commit that goes in - s
schrockn
09/04/2018, 2:05 PMshould be precisely what was shown by git diff --cached - f
freiksenet
09/04/2018, 2:05 PMthat's hasn't been a problem in my experience - f
freiksenet
09/04/2018, 2:06 PMpeople use lint-changed with eg prettier a lot - s
schrockn
09/04/2018, 2:06 PMoh man i think this is quite dangerous - f
freiksenet
09/04/2018, 2:06 PMthe assumption should be that all code is formatted xottrectku6 - f
freiksenet
09/04/2018, 2:06 PMcorrectly - f
freiksenet
09/04/2018, 2:06 PMthen no merge issues - s
schrockn
09/04/2018, 2:07 PMi think yapf runs should gate PR merges for sure - s
schrockn
09/04/2018, 2:07 PMeven the usability is problematic - s
schrockn
09/04/2018, 2:08 PM1) git commit -m “some commit with yapf problem” 2) prints out FAILED 3) commits altered commmit - f
freiksenet
09/04/2018, 2:08 PMwell whatever - f
freiksenet
09/04/2018, 2:09 PMI'll try adding format checking to tests when I have time - s
schrockn
09/04/2018, 2:10 PMya i’m a much bigger fan of that - s
schrockn
09/04/2018, 2:12 PMi wonder what python system has the best docs - f
freiksenet
09/04/2018, 2:13 PMall the ones I know uses sphinx - f
freiksenet
09/04/2018, 2:13 PMdjango, flask etx - s
schrockn
09/04/2018, 2:13 PMi guess i mean - s
schrockn
09/04/2018, 2:13 PMwhich one of the those projects - s
schrockn
09/04/2018, 2:13 PMhas the best produced docs - f
freiksenet
09/04/2018, 2:13 PMdjango - f
freiksenet
09/04/2018, 2:14 PMbest docs ever