19913d85-f662-4518-a9a1-7adc1793dfd4.png){kind=small}
Channels
#announcements
- f
freiksenet
09/11/2018, 12:00 PMhm - f
freiksenet
09/11/2018, 12:00 PMso two questions - f
freiksenet
09/11/2018, 12:00 PMCopy code# clean up temp local files # LocalFsHandleResource.clean_up_dir(pipeline_run_id) - f
freiksenet
09/11/2018, 12:00 PM^ this makes checking for files created moot - f
freiksenet
09/11/2018, 12:00 PMcause they are deleted - s
schrockn
09/11/2018, 12:01 PMyup - f
freiksenet
09/11/2018, 12:01 PMI've commented it out, I guess I should make it parametrized? - f
freiksenet
09/11/2018, 12:01 PM2. what exactly should I check for results? - f
freiksenet
09/11/2018, 12:01 PMit's clear for "file created" - f
freiksenet
09/11/2018, 12:02 PMbut what about other tests? - s
schrockn
09/11/2018, 12:02 PMso - s
schrockn
09/11/2018, 12:02 PMi think we need to have a different mode - s
schrockn
09/11/2018, 12:02 PMwhere 1) via config we say that things shouldn’t be deleted - s
schrockn
09/11/2018, 12:02 PMbut 2) still have an API where we can do it elsewhere - f
freiksenet
09/11/2018, 12:06 PMok wit that - f
freiksenet
09/11/2018, 12:06 PMwhat about "what to test" - s
schrockn
09/11/2018, 12:07 PMfor unzip file - s
schrockn
09/11/2018, 12:07 PMrun it - s
schrockn
09/11/2018, 12:07 PMsee if file exists - s
schrockn
09/11/2018, 12:07 PMfor split headers - s
schrockn
09/11/2018, 12:07 PMi would actually just do snapshot tests - s
schrockn
09/11/2018, 12:07 PMfor all of these - s
schrockn
09/11/2018, 12:07 PMpretty much - f
freiksenet
09/11/2018, 12:08 PMI wish pytest had those hahah - s
schrockn
09/11/2018, 12:08 PMthere’s a module - s
schrockn
09/11/2018, 12:08 PMit’s already in use - s
schrockn
09/11/2018, 12:08 PMin that repo - s
schrockn
09/11/2018, 12:08 PMfor their codegen tests - f
freiksenet
09/11/2018, 12:11 PMoh, ok - s
schrockn
09/11/2018, 12:12 PMsyrus (graphene guy) wrote it actually