19913d85-f662-4518-a9a1-7adc1793dfd4.png){kind=small}
Channels
#announcements
- b
Ben Gotow
09/17/2018, 5:41 AM - b
Ben Gotow
09/17/2018, 5:41 AMoh does it provide that? That’d be super interesting I think - It’d be great if we could connect the edges to the “closest edge of the box” - f
freiksenet
09/17/2018, 5:41 AMI guess they should go to sides - f
freiksenet
09/17/2018, 5:41 AMalso could try playing with connection ports - f
freiksenet
09/17/2018, 5:42 AManyway I think it's much better than before and we should merge it - b
Ben Gotow
09/17/2018, 5:42 AMyeah - I also had a mockup where we’d shrink the inputs / outputs and arrange them left-to-right, but their names are so long I’m not sure that’d work… - f
freiksenet
09/17/2018, 5:42 AMI meant connection port for links - b
Ben Gotow
09/17/2018, 5:42 AMcool! will put together a PR 👍 your layout code was really easy to reflow - nice that the rendering and the layout are in separate phases - f
freiksenet
09/17/2018, 5:43 AMiirc they are center of input / output box atm - f
freiksenet
09/17/2018, 5:43 AMmaybe they can be left or right corner - f
freiksenet
09/17/2018, 5:43 AMand we decide where to connect by checking what's closer to the other point - b
Ben Gotow
09/17/2018, 5:51 AMnice - it looks like the Dagre edge info automatically determines the “closest point on the node”, but right now we just give it the bounding box of each solid as the node rect, so they’re not quite right - b
Ben Gotow
09/17/2018, 5:51 AM - f
freiksenet
09/17/2018, 6:00 AMright, we can probably connect inputs and outputs in dagre then - f
freiksenet
09/17/2018, 6:00 AMdunno if it supports nodes that are disjoint - b
Ben Gotow
09/17/2018, 6:03 AMyeah - it seems like it might be complicated actually, I’m also letting the foreignObject do the text sizing on those inputs, so their widths aren’t given to dagre 😬 - b
Ben Gotow
09/17/2018, 6:03 AM - f
freiksenet
09/17/2018, 6:03 AMhmm - f
freiksenet
09/17/2018, 6:03 AMthis is tough - b
Ben Gotow
09/17/2018, 6:04 AM(tried making the lines /slightly/ visible through the node so you can see which green box they go with) - b
Ben Gotow
09/17/2018, 6:06 AMyeah - not quite right yet... I have some other mockups of other input / output layouts that I can try out tomorrow! I think another option would be to space them out a bit, which allows you to see the edges a bit behind them (like the right one below) - b
Ben Gotow
09/17/2018, 6:06 AM❤️ 1 - b
Ben Gotow
09/17/2018, 6:07 AMthose take up a bit more space, but maybe we could find a more compact version where there was still a bit of spacing between them - f
freiksenet
09/17/2018, 6:08 AMthis looks very nice and clean - f
freiksenet
09/17/2018, 6:08 AMbut yeah might be hard to see zoomed out - f
freiksenet
09/17/2018, 6:09 AMbut maybe we should have different image when zoomed out - f
freiksenet
09/17/2018, 6:09 AMwith less details - f
freiksenet
09/17/2018, 6:09 AMeg only solid names - b
Ben Gotow
09/17/2018, 6:10 AMooh yeah - I like the idea of the DAG being nice and browsable and having the user click for details / documentation. would be pretty slick if zooming in animated it into a more detailed view - f
freiksenet
09/17/2018, 6:10 AMwe could do it by eg rendering both images and selectively hiding the one not in use