https://dagster.io/ logo
Powered by
#announcements
  • f

    freiksenet

    11/15/2018, 5:32 PM
    which key is broken in a composite config
  • f

    freiksenet

    11/15/2018, 5:33 PM
    and error for the type in that key, all the way down
  • f

    freiksenet

    11/15/2018, 5:33 PM
    so I can inspect it and know what exactly is broken
  • s

    schrockn

    11/15/2018, 5:34 PM
    Can you give me the exact use case in your branch. E.g you have entered X in your editor. And what is the graphql query
  • f

    freiksenet

    11/15/2018, 5:36 PM
    any error in config will result in error
  • f

    freiksenet

    11/15/2018, 5:37 PM
    but there is no location info
  • s

    schrockn

    11/15/2018, 5:37 PM
    For execution plan query?
  • f

    freiksenet

    11/15/2018, 5:37 PM
    because those are all textual errors
  • f

    freiksenet

    11/15/2018, 5:37 PM
    there's isPipelineConfigValid root field
  • s

    schrockn

    11/15/2018, 5:38 PM
    Ah
  • s

    schrockn

    11/15/2018, 5:38 PM
    Kk
  • s

    schrockn

    11/15/2018, 5:38 PM
    So we should make that a union and then expose structured errors
  • s

    schrockn

    11/15/2018, 5:38 PM
    Need to do this anyways for the CLI tools
  • s

    schrockn

    11/15/2018, 5:38 PM
    Error messages terrible right now
  • s

    schrockn

    11/15/2018, 5:40 PM
    I can work on this
  • f

    freiksenet

    11/15/2018, 5:41 PM
    👍
  • s

    schrockn

    11/15/2018, 5:41 PM
    Probably not until Monday tho
  • f

    freiksenet

    11/15/2018, 5:43 PM
    yeah no problem
  • f

    freiksenet

    11/15/2018, 5:44 PM
    the rest of work is done there
  • f

    freiksenet

    11/15/2018, 5:44 PM
    i think
  • s

    schrockn

    11/15/2018, 5:44 PM
    Cool
  • f

    freiksenet

    11/15/2018, 5:44 PM
    maybe some small fixes
  • s

    schrockn

    11/15/2018, 5:44 PM
    What’s next?
  • f

    freiksenet

    11/15/2018, 5:46 PM
    figuring out where to put this
  • f

    freiksenet

    11/15/2018, 5:47 PM
    working with existing config files
  • f

    freiksenet

    11/15/2018, 5:47 PM
    scaffolding maybe
  • s

    schrockn

    11/15/2018, 5:47 PM
    Cool. I would prioritize existing files and where to put this
  • s

    schrockn

    11/15/2018, 5:48 PM
    Especially having type browser in scope optionally
  • s

    schrockn

    11/15/2018, 5:51 PM
    Also getting to a spot to merge would be good
  • s

    schrockn

    11/15/2018, 5:51 PM
    This is pretty isolated atm so no reason for it not to be in master imo
1...676869...185Latest