https://dagster.io/ logo
Powered by
#announcements
  • s

    schrockn

    11/30/2018, 1:36 PM
    to avoid namespacing collisions
  • s

    schrockn

    11/30/2018, 1:36 PM
    *name collisions
  • s

    schrockn

    11/30/2018, 1:39 PM
    @freiksenet anything i can do to be more helpful in the next couple of hrs
  • f

    freiksenet

    11/30/2018, 1:39 PM
    not really
  • f

    freiksenet

    11/30/2018, 1:40 PM
    I'm just deep into refactoring, it's hard to split that up
  • s

    schrockn

    11/30/2018, 1:40 PM
    👍
  • s

    schrockn

    11/30/2018, 1:40 PM
    yup totally understand
  • s

    schrockn

    11/30/2018, 1:40 PM
    makes sense
  • s

    schrockn

    11/30/2018, 2:07 PM
  • s

    schrockn

    11/30/2018, 2:07 PM
  • s

    schrockn

    11/30/2018, 2:07 PM
    basically totally got rid of “ExecutionContextUserParams”
  • s

    schrockn

    11/30/2018, 2:07 PM
    the object the user creates is “ExecutionContext”
  • s

    schrockn

    11/30/2018, 2:08 PM
    and then the system ends up creating a “RuntimeExecutionContext”
  • s

    schrockn

    11/30/2018, 2:09 PM
    1) advantages: when user creates an ExecutionContext they aren’t using some weird API 2) disadvantages: when user does an instanceof check or prints out the info.context it is a different class than way they created
  • s

    schrockn

    11/30/2018, 2:10 PM
    note: I am leaning towards getting users away from creating ExecutionContexts directly anyways, and instead having them manage loggers and resources instead. but not quite there yet. if we get there though these naming concerns will not matter.
  • f

    freiksenet

    11/30/2018, 2:12 PM
    this looks nice
  • f

    freiksenet

    11/30/2018, 2:12 PM
    I think printout/instanceof should be fine
  • f

    freiksenet

    11/30/2018, 2:12 PM
    not that big of a deal
  • s

    schrockn

    11/30/2018, 2:12 PM
    cool
  • s

    schrockn

    11/30/2018, 2:14 PM
    will merge
  • b

    Ben Gotow

    12/01/2018, 1:47 AM
    ok guys think I’ve got codemirror working nicely now - put up a PR with all the fixes: https://github.com/dagster-io/dagster/pull/320
  • s

    schrockn

    12/01/2018, 1:47 AM
    love it
  • s

    schrockn

    12/01/2018, 1:47 AM
    got an email notif about it
  • s

    schrockn

    12/01/2018, 1:47 AM
    in the middle of yarn build
  • s

    schrockn

    12/01/2018, 1:47 AM
    haha
  • b

    Ben Gotow

    12/01/2018, 1:47 AM
    haha nice 🙂
  • b

    Ben Gotow

    12/01/2018, 1:48 AM
    whoops, looks like I committed some pipelines I added to dagster_examples to test lists by accident - will fix that
  • s

    schrockn

    12/01/2018, 1:51 AM
    you know what a nice feature to implement would be
  • b

    Ben Gotow

    12/01/2018, 1:51 AM
    I also fixed the tabs PR (https://github.com/dagster-io/dagster/pull/313) - it looks like I didn’t re-create my .vscode folder after we gitignored it so prettier stopped running automatically
  • s

    schrockn

    12/01/2018, 1:51 AM
    cmd-/
1...777879...185Latest