19913d85-f662-4518-a9a1-7adc1793dfd4.png){kind=small}
Channels
#announcements
- f
freiksenet
12/03/2018, 12:45 PMHAHAHHAHAHHAHAHAH - f
freiksenet
12/03/2018, 12:45 PMoh my fucking god - f
freiksenet
12/03/2018, 12:46 PMsigh - s
schrockn
12/03/2018, 12:55 PMoh boy - f
freiksenet
12/03/2018, 12:55 PMhttps://github.com/graphql-python/graphql-core/pull/147 this fixes this - f
freiksenet
12/03/2018, 12:55 PMbut for some reason closed - f
freiksenet
12/03/2018, 12:55 PMvendor in graphql-core? - f
freiksenet
12/03/2018, 12:56 PMI suspect that's the best way - f
freiksenet
12/03/2018, 12:56 PMto fix this - s
schrockn
12/03/2018, 12:56 PMwhat do you mean vendor? - f
freiksenet
12/03/2018, 12:57 PMI mean, add it to our repository - f
freiksenet
12/03/2018, 12:57 PMapply patch - f
freiksenet
12/03/2018, 12:57 PMinstall local version in pip - s
schrockn
12/03/2018, 12:57 PMoh - s
schrockn
12/03/2018, 12:58 PMcan it not be fixed by a patch to graphql-ws - f
freiksenet
12/03/2018, 12:58 PMthe issue is with graphql-core - f
freiksenet
12/03/2018, 12:58 PMgraphql-ws just has a workaround - f
freiksenet
12/03/2018, 12:58 PMthat makes gevent to run is sync mode - f
freiksenet
12/03/2018, 12:58 PMcause it's more important to ship demoable stuff than working stuff ofc - f
freiksenet
12/03/2018, 12:59 PMsee the attached patch - s
schrockn
12/03/2018, 12:59 PMi see - f
freiksenet
12/03/2018, 1:00 PMsadly it's done with functions so I can't even monkey patch it, like I can with graphql_ws - s
schrockn
12/03/2018, 1:00 PMwell let’s make sure to get in contact with syrus - s
schrockn
12/03/2018, 1:02 PMso how does this work if we use the SyncExecutor - f
freiksenet
12/03/2018, 1:03 PMit's blocking - f
freiksenet
12/03/2018, 1:04 PMwhich could be fine - f
freiksenet
12/03/2018, 1:04 PMit's just that I'm annoyed by the fact that "GeventSubscriptionServer" is using SyncExecutor and not Gevent and it took me an hour to debug - f
freiksenet
12/03/2018, 1:04 PMwhy tests aren't running - s
schrockn
12/03/2018, 1:04 PMright - s
schrockn
12/03/2018, 1:04 PMi also burned some time on it itoo