19913d85-f662-4518-a9a1-7adc1793dfd4.png){kind=small}
Hey folks, is there way to programmatically delete...
# ask-communityv
Vivek Ayer
03/30/2023, 4:59 PMHey folks, is there way to programmatically delete a branch deployment on dagster cloud? Need to be able to clean up dagster cloud when a github PR is merged. Thanks in advance!
🤖 1
b
ben
03/30/2023, 8:06 PMHi Vivek, the GitHub Actions for branch deployments should mark the branch as “closed” when a PR is merged/closed. That will hide it from the UI (& branch deployment agent infra spins down automatically after a timeout). Are you interested in explicitly deleting? Archiving is our default to keep e.g. run history around
v
Vivek Ayer
03/30/2023, 8:20 PMThanks for the reply Ben, based on what I can see, it looks like there a bug in hiding closed and merged branches. If it spins the agent, I think that’s fine, just want to have a view where it’s not spammy with old PRs
b
ben
03/30/2023, 8:21 PMDo the branches show up as closed or merged in the UI? It may be an error in marking them as closed/merged on the GH Actions end.
đź‘Ť 1
ben
03/30/2023, 8:21 PMOpen branches will have this green icon
v
Vivek Ayer
03/30/2023, 8:22 PMI might have to update my deployment agents to the latest version
Vivek Ayer
03/30/2023, 8:23 PMright now if I toggle
Show closed and merged branchesb
ben
03/30/2023, 8:24 PMDo they have the merged/closed icon? Just trying to determine where the error might be happening (e.g. they aren’t being marked merged/closed or they aren’t being hidden)
v
Vivek Ayer
03/30/2023, 8:26 PMScreenshot 2023-03-30 at 4.26.12 PM.png
Vivek Ayer
03/30/2023, 8:26 PMhere’s what I see now
b
ben
03/30/2023, 8:27 PMHmm, yeah, it looks like we aren’t marking them as closed. Are you using the GitHub Action to create branch deployments?
v
Vivek Ayer
03/30/2023, 8:27 PMyup using the action
Vivek Ayer
03/30/2023, 8:29 PMVivek Ayer
03/30/2023, 8:30 PMIf you can file a github issue for it, I can track the progress there, Thanks @ben!
b
ben
03/30/2023, 8:31 PMI can do that! Do you see any failing github action runs for closed branches?
đź‘Ť 1
v
Vivek Ayer
03/30/2023, 8:34 PMSo the way I have it now is 3 actions
b
ben
03/30/2023, 8:35 PMSet up tracking issue here
v
Vivek Ayer
03/30/2023, 8:35 PM1 action for PR open
Vivek Ayer
03/30/2023, 8:35 PM1 action for Merge into main branch
Vivek Ayer
03/30/2023, 8:35 PM1 action for PR close
Vivek Ayer
03/30/2023, 8:35 PMthis might just be a configuration issue on my end
Vivek Ayer
03/30/2023, 8:36 PMthe PR close action is currently a stub
Vivek Ayer
03/30/2023, 8:36 PMbecause it was unclear how PR open or Merge into main branch would handle
b
ben
03/30/2023, 8:36 PMAhh yeah that may be the case. The “create or update branch” action will tell Dagster that the PR is closed if the PR state is closed/merged
v
Vivek Ayer
03/30/2023, 8:37 PMahhh
Vivek Ayer
03/30/2023, 8:42 PMwhere is the
create or update branchVivek Ayer
03/30/2023, 8:42 PMI’m trying to look for it
b
ben
03/30/2023, 8:49 PMAh sorry, the hybrid branch deploy action. It calls
create or update branchben
03/30/2023, 8:50 PMHere you can see it passes the PR status alongside the PR info to update the status in Dagster Cloud: https://github.com/dagster-io/dagster-cloud-action/blob/main/actions/hybrid_branch_deploy/action.yml#LL69-L79C71
v
Vivek Ayer
03/30/2023, 8:58 PMgot it!
Vivek Ayer
03/30/2023, 9:21 PMso basically i can merge my PR close action with my PR open action?
b
ben
03/30/2023, 9:32 PMYes, that should be fine. Under the hood the action will do different things based on the PR state
đź‘Ť 1
ben
03/30/2023, 9:32 PMe.g. here you’ll see it only builds images for open PRs, a closed PR will skip this step and only update the state in the UI https://github.com/dagster-io/dagster-cloud-action/blob/main/actions/hybrid_branch_deploy/action.yml#L57
v
Vivek Ayer
03/30/2023, 9:41 PMah perfect! thanks @ben!
Vivek Ayer
03/31/2023, 4:34 PM@ben all looks good, I was able to get it working! Thanks!
b
ben
03/31/2023, 5:13 PMFantastic! Glad to hear
2 Views