Nicholas Lilleyman
07/19/2023, 2:33 PMSean Lopp
07/19/2023, 3:45 PMlocations:
- location_name: ph-bi-elt
code_source:
package_name: quickstart_elt
build:
directory: ./
registry: europe-west1-docker.pkg.dev/********
Nicholas Lilleyman
07/19/2023, 4:31 PMSean Lopp
07/19/2023, 4:40 PMShalabh Chaturvedi
07/19/2023, 5:25 PMdagster_cloud.yaml
here in a code block? Are you getting this error from CI/CD or a specific command?Nicholas Lilleyman
07/20/2023, 7:57 AMlocations:
- location_name: ph-bi-elt
code_source:
package_name: quickstart_elt
build:
directory: ./
registry: europe-west1-docker.pkg.dev/********
Nicholas Lilleyman
07/20/2023, 7:59 AM% dagster-cloud workspace sync -w dagster_cloud.yaml
Shalabh Chaturvedi
07/20/2023, 2:23 PMdagster-cloud workspace add-location --location-file=dagster_cloud.yaml --location-name=ph-bi-elt
This is one used in our CICD deploy workflows. I'll look into why the sync
command seems to be broken right now.Nicholas Lilleyman
07/20/2023, 2:42 PMError: Some locations failed to load after being synced by the agent:
Error loading ph-bi-elt: {'__typename': 'PythonError', 'message': "Exception: Your agent's configuration requires you to specify an image. Use the `--image` flag when specifying your location to tell the agent which image to use to load your code.\n", 'stack': [' File "/dagster-cloud/dagster_cloud/workspace/user_code_launcher/user_code_launcher.py", line 1301, in _reconcile\n self._check_for_image(code_deployment_metadata)\n', ' File "/dagster-cloud/dagster_cloud/workspace/user_code_launcher/user_code_launcher.py", line 1064, in _check_for_image\n raise Exception(\n']}
Nicholas Lilleyman
07/20/2023, 2:43 PMShalabh Chaturvedi
07/20/2023, 3:20 PM--image
in your registry that you want to deploy.
Have you built and published a dagster image to your registry?Shalabh Chaturvedi
07/20/2023, 3:25 PM--image
parameter for add-location
.Nicholas Lilleyman
07/21/2023, 8:28 AMdagster-cloud workspace add-location --location-file=dagster_cloud.yaml --location-name=ph-bi-elt --image=europe-west1-docker.pkg.dev/prj-ops-artifact-registry-707c/container/bi/dagster:5e142d4234fa1e2010eb0d86e1cdef08c434c9bf-5599647162-1-quickstart_etl
That said, I’m overall pretty confused what the Dagster development workflow looks like… Struggling to conceptualise it and explain it to my team, do we:
• Make changes to code locally
• commit to branch
• push to remote
• create PR to master
• PR triggers GitHub action that dumps an image of my branch into the registry
• Run ‘dagster-cloud workspace add-location’ command locally to load this specific image into Dagster Cloud??
• Execute jobs in Dagster Cloud, verify their success
• Merge to Master
• ...???Shalabh Chaturvedi
07/21/2023, 8:58 AMdagster-cloud workspace add-location
locally unless you want to update something one-off outside CICD. The github workflow will do everything necessary to update the code location: create the branch deployment for the PR if needed, build and upload the docker image, update the code location to point to the new image.
Other than that the workflow above sounds reasonable.
If you want to set up GitHub the best template to follow is here: https://github.com/dagster-io/dagster-cloud-hybrid-quickstart/Nicholas Lilleyman
07/21/2023, 10:20 AMShalabh Chaturvedi
07/21/2023, 8:39 PMNicholas Lilleyman
07/24/2023, 7:39 AMShalabh Chaturvedi
07/24/2023, 5:07 PMUpdate build session with image tag
but no logs for Deploy to dagster cloud
. Can you please verify you have this section in your workflow yaml: https://github.com/dagster-io/dagster-cloud-hybrid-quickstart/blob/46bfd6c31966cda[…]0fba852f5cb2777343a4/.github/workflows/dagster-cloud-deploy.ymlNicholas Lilleyman
07/24/2023, 5:35 PMShalabh Chaturvedi
07/24/2023, 5:37 PMNicholas Lilleyman
07/24/2023, 5:37 PMShalabh Chaturvedi
07/24/2023, 7:19 PMError: No Dagster Cloud agent is actively heartbeating. Make sure that you have a Dagster Cloud agent running
. Have you enabled branch deployments on this agent? For eg there's a flag in ECS: https://docs.dagster.io/dagster-cloud/deployment/agents/amazon-ecs/creating-ecs-agent-new-vpc#step-3-configure-the-agentShalabh Chaturvedi
07/24/2023, 8:59 PMNicholas Lilleyman
07/25/2023, 8:03 AM