dhume
10/13/2020, 8:16 PMdagster.yaml
I have the launcher setup like below
run_launcher:
module: dagster_aws.ecs.launcher
class: ECSRunLauncher
config:
key_id:
env: AWS_ACCESS_KEY_ID
access_key:
env: AWS_SECRET_ACCESS_KEY
region_name:
env: AWS_DEFAULT_REGION
imagename:
env: ECR_IMAGE
family: dagit
memory: 256
cpu: 512
grab_logs: False
I’m running into this error Error 1: Invalid scalar at the root. Value "FARGATE" of type "<class 'str'>" is not valid for expected type "Bool".
which I’m guessing is due to the default for grab_logs is a string rather than a boolean. https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagster-aws/dagster_aws/ecs/launcher.py#L140 That minor issue aside I’m not sure when I run dagit
it picks up I want to use a non standard launcher but isn’t overriding the default value since I have that set.alex
10/13/2020, 8:40 PMdhume
10/13/2020, 8:53 PMalex
10/13/2020, 8:54 PMdhume
10/13/2020, 8:55 PMalex
10/13/2020, 8:58 PMdhume
10/13/2020, 9:00 PMalex
10/13/2020, 9:04 PMECSRunLauncher
is actually pretty close - the ECSClient
its built on is under test, the remaining issue aside from the config is generating the right dagster api execute_run_with_structured_logs
command instead of having command be part of the configdhume
10/13/2020, 9:10 PMECSRunLauncher
. If I update to 0.9.15 would this be enough for this to be working or as the commit suggests is this just a stepalex
10/14/2020, 8:16 PMdhume
10/14/2020, 8:18 PMAttributeError: 'NoneType' object has no attribute 'run_id'
File "/Users/dennishume/code/dagster/env/lib/python3.7/site-packages/dagster_graphql/implementation/utils.py", line 14, in _fn
return fn(*args, **kwargs)
File "/Users/dennishume/code/dagster/env/lib/python3.7/site-packages/dagster_graphql/implementation/execution/launch_execution.py", line 19, in launch_pipeline_execution
return _launch_pipeline_execution(graphene_info, execution_params)
File "/Users/dennishume/code/dagster/env/lib/python3.7/site-packages/dagster_graphql/implementation/execution/launch_execution.py", line 52, in _launch_pipeline_execution
run=graphene_info.schema.type_named("PipelineRun")(run)
File "/Users/dennishume/code/dagster/env/lib/python3.7/site-packages/dagster_graphql/schema/runs.py", line 131, in __init__
runId=pipeline_run.run_id, status=pipeline_run.status, mode=pipeline_run.mode
alex
10/20/2020, 5:57 PMDAGSTER_HOME
& dagster.yaml
set up to point at the same instance you are launching form - configured to use an RDS database or whateverdhume
10/20/2020, 6:03 PMdagit
locally while testing this, the the task launches in AWS and is using RDS, I need to configure my local dagster.yaml
to also be configured for that RDS instance in the run_storage
and event_log_storage
. Right now my local yaml is only configured for the run_launcher
alex
10/20/2020, 6:05 PMdhume
10/20/2020, 6:05 PMalex
10/20/2020, 6:07 PM~/data/dagster
as my default DAGSTER_HOME
then have a ~/data/dagster-remote
for one with instance configured for RDSdhume
10/22/2020, 8:13 PM