Michel Rouly
07/29/2021, 3:05 PMdagster/dagster
and dagster/dagster-user-deployments
helm charts, there's no way to set environment variables on pipeline runs from the dagster-user-deployments
release. You can only influence them via pipelineRun
in the dagster
deployment.
Which strikes me as odd. What if independent dagster-user-deployments
require independent environment variable settings?Michel Rouly
07/29/2021, 3:06 PMMichel Rouly
07/29/2021, 3:08 PMpipelineRun.image
looks like it's the user-deployment image.
Feels like this is just a missing feature of the dagster/dagster-user-deployments
chart, it doesn't fully mirror / implement its own pipelineRun
.rex
07/29/2021, 3:14 PM1/ the run launcher loads the environment variables from a configmap. currently, this configmap is from created from.Values.pipelineRun
2/ Instead, we can have each user-code-deployment have a configmap of environment vars (or maybe just one configmap for all the user-code-deployments).
3/ You can specify the name for the configmap, and then add the name of this configmap to the celery run config so that it knows it load from this configmap (rather than the one created by).Values.pipelineRun
4/ so now you can update the environment variables in thechart, rather than updatingdagster-user-deployments
.Values.pipelineRun
That should decouple the dependency of, so that we can finally remove itpipelineRun
rex
07/29/2021, 3:15 PMextraManifests
section of dagster-user-deployments
Michel Rouly
07/29/2021, 3:15 PMMichel Rouly
07/29/2021, 3:18 PMextraManifests
, where does it get added in step 3/ ?
add the name of this configmap to the celery run configIs that specified in the pipeline tags?
rex
07/29/2021, 3:23 PMenv_config_maps
Michel Rouly
07/29/2021, 3:26 PMwhich you can provide aswait, what? I didn't know that. the examples on that page are all either YAML via dagit/CLI or in python.env_config_maps
Michel Rouly
07/29/2021, 3:26 PMMichel Rouly
07/29/2021, 3:27 PMMichel Rouly
07/29/2021, 3:28 PMenv_config_maps
as they key in those tags.Michel Rouly
07/29/2021, 3:28 PMrex
07/29/2021, 3:32 PMrex
07/29/2021, 3:33 PMenv_config_maps
Michel Rouly
07/29/2021, 3:34 PMcelery_executor
you're saying accepts env_config_maps
in its run config?rex
07/29/2021, 3:34 PMMichel Rouly
07/29/2021, 3:35 PMmultiprocess_executor
so far, so I hadn't seen that config key.rex
07/29/2021, 3:37 PM.pipelineRun
was mostly an artifact for configuring the celery executorMichel Rouly
07/29/2021, 3:39 PMconfigmap
to a pipeline pod.Michel Rouly
07/29/2021, 3:40 PMdagster/dagster
helm release, which is fine.