After upgrading from version 0 10 1 to 0 10 7 `dagster k8s c dagster #deployment-kubernetes

After upgrading from version 0.10.1 to 0.10.7, `da...

William Sheu

02/27/2021, 12:46 AM

After upgrading from version 0.10.1 to 0.10.7,

dagster-k8s/config

seems to no longer work for the spawned jobs -- I have this annotation on both my pipeline and each of my solids; it seems to be applied properly to the

dagster-run

jobs, but not the

dagster-job

jobs anymore. Did something change about the behavior of these tags?

William Sheu

02/27/2021, 1:10 AM

false alarm, seems to be working in one of my repositories but not another 🤔

William Sheu

02/27/2021, 1:23 AM

as far as I can tell, the only difference was defining the config tags at solid definition time vs. applying them afterwards (

some_solid = some_solid.tag(**some_solid.tags, { <k8s config tags> })

). Changing this seems to have fixed it.

alex

03/01/2021, 4:26 PM

can you share a gist or other form of code snippet to show what did not work and what did work? Sounds like there might be a bug we should fix here

William Sheu

03/01/2021, 11:15 PM

didn't work after upgrading to 0.10.7 (worked in 0.10.1) ^^

original

William Sheu

03/01/2021, 11:17 PM

Worked after this change

fixed

alex

03/01/2021, 11:35 PM

Thanks a ton! I think i found the bug edit: yep, fix should go out on Thursday

Matyas Tamas

03/01/2021, 11:55 PM

Mind linking the diff? I want to see if it’s related to another config issue I’m checking out.

alex

03/02/2021, 12:10 AM

https://dagster.phacility.com/D6729

👍 1

Open in Slack

Previous Next