19913d85-f662-4518-a9a1-7adc1793dfd4.png){kind=small}
<@U01EK4V7BM4> just to confirm the syntax for the ...
# deployment-ecst
Tiri Georgiou
03/21/2022, 8:58 AM@jordan just to confirm the syntax for the changes here… As an example
Copy code
run_launcher:
module: dagster_aws.ecs
class: "EcsRunLauncher"
config:
secrets:
- name: "SLACK_TOKEN"
valueFrom: "arn:aws:secretsmanager:eu-west-1:XXXXXXXX:secret:dagster/slack-a8jmKZ:SLACK_TOKEN::" Copy code
2022-03-21T08:41:26.634+00:00 raise ScannerError(None, None,
2022-03-21T08:41:26.634+00:00
Copy
yaml.scanner.ScannerError: mapping values are not allowed here
yaml.scanner.ScannerError: mapping values are not allowed here
2022-03-21T08:41:26.634+00:00
Copy
in "/opt/dagster/dagster_home/dagster.yaml", line 16, column 106
in "/opt/dagster/dagster_home/dagster.yaml", line 16, column 106Tiri Georgiou
03/21/2022, 1:31 PMactually I sorted it by moving it one indent space behind i.e.
Copy code
run_launcher:
module: dagster_aws.ecs
class: "EcsRunLauncher"
config:
secrets:
- name: "SLACK_TOKEN"
valueFrom: "arn:aws:secretsmanager:eu-west-1:XXXXXXXX:secret:dagster/slack-a8jmKZ:SLACK_TOKEN::"j
jordan
03/21/2022, 2:18 PMyaml blob sad
i’ll put a fix in for the docs. thanks for raising this!
✅ 1
jordan
03/25/2022, 2:39 PMI’m having trouble reproducing this - both indented and unindented are loading for me. Are you sure it was that particular change that fixed it? Do you have a more complete stack-trace? what versions of dagster, PyYAML, and python are you using?
jordan
03/25/2022, 2:41 PMactually i can reproduce it if i remove the quotes from the secret arn
which is also inaccurate in the docs but looks like it’s already been corrected in your original post
i’ll update the docs with that fix at least
jordan
03/25/2022, 2:43 PMt
Tiri Georgiou
03/25/2022, 2:46 PMYes it might have initially been without quotes when the error hit. I had written the post ^^ after I was playing around with it. Yaml pains
Tiri Georgiou
03/25/2022, 2:46 PM😞
Tiri Georgiou
03/25/2022, 2:47 PMCould be due to the characters of colons ending in the arn? (Assume yaml reads that as a mapping operator?)
j
jordan
03/25/2022, 2:48 PMI’m pretty sure that’s exactly what’s happening
jordan
03/25/2022, 2:48 PMThanks for surfacing this!
t
Tiri Georgiou
03/25/2022, 2:49 PMNo probs 👌
2 Views