https://dagster.io/ logo
#dagster-support
Title
# dagster-support
s

Stefan Samba

08/09/2022, 12:18 PM
Broken link To reproduce: • Access from: https://docs.dagster.io/_apidocs/libraries/dagstermill#dagstermill.DagstermillExecutionContext.log • hyperlink
dagster.DagsterLogManager
• links to https://docs.dagster.io/loggers#dagster.DagsterLogManager • Results in
404: Not Found
e

erin

08/09/2022, 1:52 PM
Hey Stefan - thanks for reporting this! We'll look into it.
❤️ 1
s

Stefan Samba

08/10/2022, 7:33 AM
Hi @erin A few more notes that might improve docs for dagstermill: • Notebooks as ops is using a
script_relative_path
as a function while declaring
k_mean_iris
. That function needs to be imported from somewhere. To me, initially, I wasn’t sure how to get that function. After googling I found this link that shows it has to be imported as
from dagster.utils import script_relative_path
Define dagstermill op docs show that 2 of the parameters are
input_defs
and
output_defs
, both of them are optional. When checking the source code of my installed package I found the following schema where these param names are not supported. Instead it’s
ins
and
outs
.
Copy code
def define_dagstermill_op(
    name: str,
    notebook_path: str,
    ins: Optional[Mapping[str, In]] = None,
    outs: Optional[Mapping[str, Out]] = None,
    config_schema: Optional[Union[Any, Dict[str, Any]]] = None,
    required_resource_keys: Optional[Set[str]] = None,
    output_notebook_name: Optional[str] = None,
    asset_key_prefix: Optional[Union[List[str], str]] = None,
    description: Optional[str] = None,
    tags: Optional[Dict[str, Any]] = None,
):
Perhaps I’m using another version? It feels like the docs on Dagstermill could be more extensive and more accurate. Keep up the good work!
2 Views