Hi there I see in the API reference for the `dagster aws sec

Question

Hi there I see in the API reference for the `dagster aws secretsmanager secretsmanager secrets resource` definition that a `context` ref is passed to a job function in the example however this doesn t seem to be allowed at runtime as I get the reserved keyword error Are the docs incorrect or am I perhaps missing something I m referring to this block in particular ``` job resource defs= secrets secretsmanager secrets resource def example job context example secretsmanager secrets op example secretsmanager secrets op 2 ```

prha · Answer

Hi André Is there a stacktrace that you can share

André Jordaan · Answer

Hi Phil sure here it is ```docker example user code | Traceback most recent call last docker example user code | File usr local bin dagster line 8 in lt module gt docker example user code | sys exit main docker example user code | File usr local lib python3 7 site packages dagster cli init py line 50 in main docker example user code | cli auto envvar prefix=ENV PREFIX pylint disable=E1123 docker example user code | File usr local lib python3 7 site packages click core py line 1130 in call docker example user code | return self main args kwargs docker example user code | File usr local lib python3 7 site packages click core py line 1055 in main docker example user code | rv = self invoke ctx docker example user code | File usr local lib python3 7 site packages click core py line 1657 in invoke docker example user code | return process result sub ctx command invoke sub ctx docker example user code | File usr local lib python3 7 site packages click core py line 1657 in invoke docker example user code | return process result sub ctx command invoke sub ctx docker example user code | File usr local lib python3 7 site packages click core py line 1404 in invoke docker example user code | return ctx invoke self callback ctx params docker example user code | File usr local lib python3 7 site packages click core py line 760 in invoke docker example user code | return callback args kwargs docker example user code | File usr local lib python3 7 site packages dagster cli api py line 571 in grpc command docker example user code | container context=json loads container context if container context = None else None docker example user code | File usr local lib python3 7 site packages dagster grpc server py line 835 in init docker example user code | container context=container context docker example user code | File usr local lib python3 7 site packages dagster grpc server py line 213 in init docker example user code | loadable target origin self entry point docker example user code | File usr local lib python3 7 site packages dagster grpc server py line 99 in init docker example user code | loadable target origin attribute docker example user code | File usr local lib python3 7 site packages dagster grpc utils py line 33 in get loadable targets docker example user code | else loadable targets from python file python file working directory docker example user code | File usr local lib python3 7 site packages dagster core workspace autodiscovery py line 26 in loadable targets from python file docker example user code | loaded module = load python file python file working directory docker example user code | File usr local lib python3 7 site packages dagster core code pointer py line 86 in load python file docker example user code | return import module from path module name python file docker example user code | File usr local lib python3 7 site packages dagster seven init py line 47 in import module from path docker example user code | spec loader exec module module docker example user code | File lt frozen importlib bootstrap external gt line 728 in exec module docker example user code | File lt frozen importlib bootstrap gt line 219 in call with frames removed docker example user code | File repo py line 72 in lt module gt docker example user code | job resource defs= secrets secretsmanager secrets resource docker example user code | File usr local lib python3 7 site packages dagster core definitions decorators job decorator py line 70 in call docker example user code | config mapping=None docker example user code | File usr local lib python3 7 site packages dagster core definitions composition py line 1003 in do composition docker example user code | exclude nothing=False docker example user code | File usr local lib python3 7 site packages dagster core definitions decorators solid decorator py line 404 in resolve checked solid fn inputs docker example user code | for inferred in inferred props values docker example user code | File usr local lib python3 7 site packages dagster core definitions decorators solid decorator py line 405 in lt genexpr gt docker example user code | if inferred name in inputs to infer docker example user code | File usr local lib python3 7 site packages dagster core definitions input py line 237 in create from inferred docker example user code | default value=inferred default value docker example user code | File usr local lib python3 7 site packages dagster core definitions input py line 88 in init docker example user code | self name = check valid name name if name else None docker example user code | File usr local lib python3 7 site packages dagster core definitions utils py line 54 in check valid name docker example user code | f name is not a valid name in Dagster It conflicts with a Dagster or python reserved keyword docker example user code | dagster core errors DagsterInvalidDefinitionError context is not a valid name in Dagster It conflicts with a Dagster or python reserved keyword docker example user code exited with code 1```

prha · Answer

Hi André This is a bug in our example code I think you should omit the `context` arg from the job and everything should work correctly ``` job resource defs= secrets secretsmanager secrets resource def example job example secretsmanager secrets op example secretsmanager secrets op 2 ```

prha · Answer

We ll get a fix out for the docs this week

André Jordaan · Answer

Thanks Phil I appreciate your time and feedback Just a last question related to your implementation of the `secretsmanager secrets resource` I am able to pull the secrets from AWS Secrets Manager and can see via the logs that it s being stored in the ` opt dagster dagster home storage XX XX XX XX XX OP NAME result` directory however it s not being added as an ENV var even though I have `add to environment` set to `True` The documentation does not give an indication of where to name the ENV var you want it to be saved to and it does not seem like it s assigning a default name either

prha · Answer

cc < ben> who might know this better I think the secrets stored within secretsmanager are stored as environment variables name value individually within the scope of the resource So if an `op` includes the secrets manager resource then the op should have access to those individual secrets

prha · Answer

Here s a unittest that exercises this in case that s helpful <https github com dagster io dagster blob 9f8e68fec0833469a72f93e0107b5c38d7d98031 python modules libraries dagster aws dagster aws tests secretsmanager tests test secrets py L112|https github com dagster io dagster blob 9f8e68fec0833469a72f93e0107b5c38d7d9803 ster aws dagster aws tests secretsmanager tests test secrets py>

ben · Answer

Yes the environment variables should be made available in the scope of the resource so the body of the op which requires the resource You can also access them directly from the resource object

André Jordaan · Answer

Thanks for the feedback guys Much appreciated I ve been able to access the vars within the scope of the op