https://dagster.io/ logo
Title
c

Christos Sarakasidis

11/04/2021, 3:10 PM
Hi Team, My name in Chris Sarakasidis - Data Engineer, Sainsburys. We use dagster (v 0.11.11) on a daily basis to orchestrate our pipelines. Yesterday we cancelled a production pipeline from the UI (see image attached below), but unfortunately it didn’t terminate the job. The job continued and completed causing various issues. This wasn’t the first time it happened, so we are wondering if this is a known bug that was fixed in subsequent versions or there is something else happening that we should be aware of.
p

prha

11/04/2021, 4:34 PM
Hi Christos. Can you share what you’ve configured for your run launcher? Are you using the
DefaultRunLauncher
?
c

Christos Sarakasidis

11/04/2021, 4:38 PM
thanks for the reply @prha, we use
DockerRunLauncher
(runs on AWS ECS Fargate)
p

prha

11/04/2021, 5:09 PM
Also, do you have a run_coordinator configured?
c

Christos Sarakasidis

11/04/2021, 5:10 PM
yes, here it is:
run_coordinator:
  module: dagster.core.run_coordinator
  class: QueuedRunCoordinator
  config:
    tag_concurrency_limits:
      - key: "pipeline"
        value: "product_matching"
        limit: 1
p

prha

11/04/2021, 5:11 PM
cc @daniel
d

daniel

11/04/2021, 5:13 PM
Hi Christos - when you terminated the run, did you check the 'force terminate' checkbox? That "the computational resources may not be fully cleaned up" message is reflected in the fact that the run kept going
if that's the only option that's available, dagit might not have enough visibility into your docker environment to find the container to kill the run - does it have access to your docker context?
c

Christos Sarakasidis

11/04/2021, 5:28 PM
these computational resources refer to AWS resources corresponding to the solids. But the pipeline on dagster why wasn’t terminated?
d

daniel

11/04/2021, 5:32 PM
It's actually referring to the run worker as well (the docker container spun up by the run launcher) - if you want to make sure that all the resources spun up by your run get cleaned up (including the container) you don't want to click that checkbox
c

Christos Sarakasidis

11/04/2021, 5:38 PM
so when we actually want to cancel the pipeline (i.e., kill the container launched by the run launcher) what should we do?
d

daniel

11/04/2021, 5:40 PM
the terminate button should give you an option to terminate it (without the checkbox that says "Force Terminate"). Are you only seeing the option to force terminate?
if you're only seeing the option to force terminate, that means that dagit can't find the container to stop it - which would indicate to me that it needs to be configured in such a way that it has access to your docker client (you might see this, for example, if you mounted the docker socket as a volume in your daemon, but not in dagit)