https://dagster.io/ logo
Title
b

Billie Thompson

05/19/2021, 4:35 PM
Hey, I am trying to work out how to deploy into a dagit into a kubernetes where the user deployment is in a image that requires pull secrets, and the imagePullSecrets never seem to get used, am I missing a step or something here, I also can’t see how to pass the secret on to the Run Worker
d

daniel

05/19/2021, 4:42 PM
hi Billie - if you're setting it in the helm chart, it should be set in the user deployment here: https://sourcegraph.com/github.com/dagster-io/dagster/-/blob/helm/dagster/charts/dagster-user-deployments/templates/deployment-user.yaml#L32:7 Is that different than what you're seeing?
Except in our own values.yaml
d

daniel

05/19/2021, 4:44 PM
Yeah, I'd expect that to work. I'd have to check about the run worker though
b

Billie Thompson

05/19/2021, 4:46 PM
So our current theory is that it’s not setting the value in the subchart, because it’s not a global variable
We actually tried deploying the subchart by itself and it didn’t have a variable we could set for imagePullSecrets
d

daniel

05/19/2021, 4:47 PM
cc @rex re: the above
b

Billie Thompson

05/19/2021, 4:48 PM
(might be wrong about the subchart missing the imagePullSecrets, it’s been a long Wednesday)
d

daniel

05/19/2021, 4:51 PM
if its working as intended, i think it should apply to the run worker as well
b

Billie Thompson

05/19/2021, 4:51 PM
Is there any extra output I can show you that might help clear things up?
imagePullSecrets:
  - name: image-secret-here

deployments:
  - name: "example"
    image:
      repository: "<http://mycontainer.azurecr.io/dagster-sample|mycontainer.azurecr.io/dagster-sample>"
      tag: latest
      pullPolicy: Always
    dagsterApiGrpcArgs:
      - "-f"
      - "/app/repo.py"
    port: 3030
    envSecrets:
      - name:  some-additional-secrets
Is our values.yaml
r

rex

05/19/2021, 4:54 PM
looks like the image pull secrets are being set in the user deployment
I think you’ll need to specifiy
imagePullSecrets
under
dagster-user-deployments
rather than using
imagePullSecrets
in https://sourcegraph.com/github.com/dagster-io/dagster/-/blob/helm/dagster/values.yaml#L22
Like:
dagster-user-deployments:
  # Add secrets here
  imagePullSecrets: []

  # Creates a workspace file with the gRPC servers hosting your user code.
  enabled: true

  # If you plan on deploying user code in a separate Helm release, set this to false.
  enableSubchart: true
b

Billie Thompson

05/19/2021, 4:58 PM
We’ve worked it by giving implicit permission for the cluster
Can I ask what the best way to get new versions of the pipeline code is for this?
Should I be updating the helm chart image when I deploy, or some other method
r

rex

05/19/2021, 5:04 PM
we recommend pushing a new version of the user code image, updating the tag of the image in the helm chart, and then upgrading your Helm release
b

Billie Thompson

05/19/2021, 5:05 PM
Nice thanks! We will do that 🙂
r

rex

05/19/2021, 5:05 PM
If you have any further questions, you can post in #dagster-kubernetes!
❤️ 1
👍 1
b

Billie Thompson

05/19/2021, 5:06 PM
Thanks for all your help! Really appreciate the fast answers and Dagster is lovely to work with