https://dagster.io/ logo
Title
d

Denis Maciel

11/03/2022, 4:41 AM
HI, I am trying to upgrade Dagster to the latest version. I am using the
EcsRunLauncher
. On Dagster 1.0.15, I am getting the following error:
dagster._core.errors.DagsterInvalidConfigError: Errors whilst loading configuration for {'task_definition': Field(<dagster._config.config_type.ScalarUnion object at 0x7f702b261b50>, default=@, is_required=False), 'container_name': Field(<dagster._config.source.StringSourceType object at 0x7f703049abb0>, default=run, is_required=False), 'secrets': Field(<dagster._config.config_type.Array object at 0x7f702b261e20>, default=@, is_required=False), 'secrets_tag': Field(<dagster._config.config_type.Noneable object at 0x7f702b261370>, default=dagster, is_required=False), 'include_sidecars': Field(<dagster._config.config_type.Bool object at 0x7f7030521880>, default=False, is_required=False), 'use_current_ecs_task_config': Field(<dagster._config.config_type.Bool object at 0x7f7030521880>, default=True, is_required=False), 'run_task_kwargs': Field(<dagster._config.field_utils.Permissive object at 0x7f702b261250>, default=@, is_required=False), 'env_vars': Field(<dagster._config.config_type.Array object at 0x7f702b24f4f0>, default=@, is_required=False)}.
    Error 1: Received unexpected config entry "name" at path root:task_definition. Expected: "{ execution_role_arn?: (String | { env: String }) log_group?: (String | { env: String }) requires_compatibilities?: [String] sidecar_containers?: [{ }] task_role_arn?: (String | { env: String }) }".
And this is run launcher configuration in my
dagster.yaml
run_launcher:
  module: dagster_aws.ecs
  class: EcsRunLauncher
  config:
    task_definition:
      env: DAGSTER_RUN_TASK_DEFINITION
    container_name:
      env: DAGSTER_CONTAINER_NAME
I traced the problem back to @daniel’s commit. Was this change in behavior intended? If so, how can I pass the task definition short name as an environment variables as I was doing before?
:dagster-bot-resolve: 1
d

daniel

11/03/2022, 11:34 AM
Hi Denis - we’ll investigate today about restoring this functionality, thanks for the report - breaking it was not intentional
d

Denis Maciel

11/03/2022, 11:36 AM
hey daniel, thanks for the quick reply. I will wait for your feedback before proceeding with the upgrade.
d

daniel

11/03/2022, 11:57 PM
A fix for this will go out in the release next Thursday - the original config should work again after that. Apologies for the breakage
d

Denis Maciel

11/04/2022, 5:53 AM
amazing, thank you so much!