Zach P
03/01/2023, 6:31 PMZach P
03/01/2023, 6:34 PMShalabh Chaturvedi
03/01/2023, 6:41 PMdaniel
03/01/2023, 6:42 PMenv:
DAGSTER_CLOUD_URL: "<http://myorg.dagster.cloud>"
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
ENABLE_FAST_DEPLOYS: 'true'
Zach P
03/01/2023, 6:42 PMenv:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
ENABLE_FAST_DEPLOYS: "true"
and
- name: Build and deploy Python executable
if: env.ENABLE_FAST_DEPLOYS == 'true'
uses: dagster-io/dagster-cloud-action/actions/build_deploy_python_executable@pex-v0.1
with:
dagster_cloud_file: "$GITHUB_WORKSPACE/project-repo/dagster_cloud.yaml"
build_output_dir: "$GITHUB_WORKSPACE/build"
python_version: "3.8"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Shalabh Chaturvedi
03/01/2023, 6:51 PMDAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
with the actual URL, eg
DAGSTER_CLOUD_URL:"<http://myorg.dagster.cloud>"
It is unusual that this is still pointing to the secret. Is it possible the secret value was changed? I don't think secrets can be inspected in github so could you change that to the literal value for your org?Zach P
03/01/2023, 6:52 PMhttp
vs https
make any difference here?Shalabh Chaturvedi
03/01/2023, 6:54 PMhttp
just to be consistent with the pattern we use.daniel
03/01/2023, 6:55 PMZach P
03/01/2023, 6:57 PMZach P
03/01/2023, 6:57 PMZach P
03/01/2023, 7:02 PMZach P
03/01/2023, 7:02 PMShalabh Chaturvedi
03/01/2023, 7:05 PMZach P
03/01/2023, 7:07 PMdagster_cloud_default_deploy:
name: Dagster Serverless Deploy
runs-on: ubuntu-20.04
outputs:
build_info: ${{ steps.parse-workspace.outputs.build_info }}
steps:
# According to dagster, we were hitting rate limits on deploying new artifacts.
- name: Workflow Queue
uses: ahmadnassri/action-workflow-queue@v1.1.0
- name: Parse cloud workspace
if: env.ENABLE_FAST_DEPLOYS != 'true'
id: parse-workspace
uses: dagster-io/dagster-cloud-action/actions/utils/parse_workspace@v0.1
with:
dagster_cloud_file: dagster_cloud.yaml
- name: Checkout
if: env.ENABLE_FAST_DEPLOYS == 'true'
uses: actions/checkout@v3
with:
ref: ${{ github.head_ref }}
path: project-repo
- name: Build and deploy Python executable
if: env.ENABLE_FAST_DEPLOYS == 'true'
uses: dagster-io/dagster-cloud-action/actions/build_deploy_python_executable@pex-v0.1
with:
dagster_cloud_file: "$GITHUB_WORKSPACE/project-repo/dagster_cloud.yaml"
build_output_dir: "$GITHUB_WORKSPACE/build"
python_version: "3.8"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Shalabh Chaturvedi
03/01/2023, 7:12 PMon:
pull_request:
types: [opened, synchronize, reopened, closed]
daniel
03/01/2023, 7:13 PMZach P
03/01/2023, 7:13 PMname: Serverless Branch Deployments
on:
pull_request:
types: [opened, synchronize, reopened, closed]
Zach P
03/01/2023, 7:14 PMcompany
is me search and replacing the name of our company with company
😛daniel
03/01/2023, 7:14 PMShalabh Chaturvedi
03/01/2023, 7:19 PMgit -C {project_dir} log -1 --format=%cd --date=unix
. Right now I am unsure why because you are checking out the head_ref
which should checkout the latest commit in that branch.Zach P
03/01/2023, 7:22 PMShalabh Chaturvedi
03/01/2023, 7:23 PMZach P
03/01/2023, 7:25 PM<http://dagster.cloud/company>
instead of <http://company.dagster.cloud>
, but since it was working as of friday, I’m not sure if this is possible — unsure of what changes were in the recent update.Shalabh Chaturvedi
03/01/2023, 7:31 PMc5719b8a088d5fdd0fc2c27cc91ea23ec6e360d5
. you could try git show c5719b8a088d5fdd0fc2c27cc91ea23ec6e360d5
in your local branch to inspect. I think it should be the second last commit in the branch.
Alternatively there is a chance our DAGSTER_CLOUD_URL was set to something likeah interesting. the latest release was mainly refactoring. previously we had more github specific custom code and now we have rolled that into theinstead of<http://dagster.cloud/company>
<http://company.dagster.cloud>
dagster-cloud
command. this does change how the DAGSTER_CLOUD_URL
is passed through. i'll look into if we previously supported <http://dagster.cloud/company>
style urls.Zach P
03/01/2023, 7:35 PMShalabh Chaturvedi
03/16/2023, 7:08 PM<http://dagster.cloud/company>
style urls with the earlier release - sorry about that. The fix was rolled out early last week. However I suggest we keep the new style DAGSTER_CLOUD_URL
in the deploy.yml files.Zach P
03/16/2023, 8:44 PM