Heya What would be the preferred way providing feedback sugg

Question

Heya What would be the preferred way providing feedback suggestions to blog posts For context some things are broken or outdated with published on April 4 2023 confused

Taylor Murphy · Answer

Hey Janis I m from the Meltano team can you share what you re seeing that s wrong

JP · Answer

There seem to be some errors in the blog post as well as it seems some of the steps are not possible to walk through anymore I was just about to go through it once While at it I can make a summary on what seems to not work I ll get back to the thread in an hour or so +1

JP · Answer

Apart from some minor things that could be written better these are critical ones When following the instructions to the letter apart from using your own github token one will not be able to get past Option 1 import jobs from Meltano 1 Dagster requires Meltano library installed in its env for it to be able to run `load jobs from meltano project` function I do not know if this is by design or not but it is not installed with `dagster meltano` Maybe the blog assumes this module to be available globally and in $PATH One will be be presented with following error in terminal s stdout ``` dag melt dagster dag venv lib python3 10 site packages dagster core workspace context py 589 UserWarning Error loading repository location dag melt project FileNotFoundError Errno 2 No such file or directory meltano ``` No jobs will be visible in <http 127 0 0 1 3000 locations dag melt project jobs> To fix this one would ```source ~ dag melt dagster dag venv bin activate amp amp pip install meltano amp amp deactivate``` then restart `dagster dev` 2 One would not be able to run the job that now is available with fix in 1 because of following error ```dagster check CheckError Value in dict mismatches expected type for key MELTANO CLI LOG CONFIG Expected value of type lt class str gt Got value Users janispuris dag melt dagster dag venv lib python3 10 site packages dagster meltano logging yaml of type lt class pathlib PosixPath gt ``` I do not know if this is a breaking change in Meltano because the tutorial tells the user to install the latest version or something else anyhow I have not been able to work around this yet Honestly would not think anyone to continue with a tutorial at this point

Taylor Murphy · Answer

< Fraser Marlow> it looks like clarifying the instructions on installing Meltano would be good as well as recommending to pin a specific version Looks like the post was using 2 16

Taylor Murphy · Answer

Thanks for the specific feedback < JP>

JP · Answer

Does not seem to be a breaking change at Meltano side The blog post hints at usage of Meltano 2 16 1 so I ve reinstalled it to be that particular version to no avail same issue Looking at the stack trace it seems to be something in dagster meltano lib where it is not serialising the pathlib s path object intro string shrug

JP · Answer

This fixes the problem ```dag melt dagster dag venv lib python3 10 site packages dagster meltano meltano resource py``` change line 34 from ``` MELTANO CLI LOG CONFIG Path file parent logging yaml ``` to ``` MELTANO CLI LOG CONFIG str Path file parent logging yaml ``` The meltano job runs without issues ~I now suspect this may be a breaking change in Python 3 11 I ll try to reproduce this with 3 10~

JP · Answer

From looks of it the property is always used its type hints say it returns a `dict` with `str` for keys and values however `Path file parent logging yaml ` does not return a `str` but a `PosixPath` object hence the error I ve checked this on Python 3 11 3 10 and 3 9 shrug From what I can tell from git blame this property was introduced back in Feb 18 2023 as part of and therefore I m clueless as to how this was working at the time of writing the blog post disappointed Would you suggest me to open github issue on this

JP · Answer

Looks like this is a bug in `dagster meltano` where it was allowing non string entries to exist in the dict which was fine until a change in `dagster` package in <https github com dagster io dagster blame master python modules dagster dagster check init py|dagster python modules dagster dagster check init py at master dagster io dagster GitHub> I suspect previously the dict values were not validated but now they are hence the error Specifically this function file ```dagster check init py``` function ``` check mapping entries``` It is little too late to go further down the rabbit hole on this I ll open a PR on `dagster meltano` sometime tomorrow on shrug

Taylor Murphy · Answer

Yeah either a PR or an issue on that repo would be good +1 Thanks

Taylor Murphy · Answer

Wanted to tag < Jules Huisman Quantile > as well since he s the main contributor to that project

Fraser Marlow · Answer

Thanks < JP> for the head s up I will run back through the tutorial with your notes i hand and update it Indeed we made significant changes to the Dagster Config and Resources APIs introducing Pydantic like type checking

JP · Answer

Fraser Marlow · Answer

OK sorry for the delay I got to rerun through the tutorial tonight I am now on ```dagster version 1 2 6 meltano version 2 16 1``` and everything ran smoothly Thanks < JP> for your help on identifying and troubleshooting this one