I have a new question up on the Q&A board, can’t tell if I’m being bone-headed in my approach or if there is a problem with

failure_hook

in testing. https://github.com/dagster-io/dagster/discussions/4046

mocking the resource is the right way for testing

I am not able to do that, as it belongs to our client under NDA. The interesting thing is that the testing for the success_hook passes just fine and is mocked in similar fashion. It almost seems that when an exception is raised in the solid then the failure hook is not called and execution stops. Is it possible that we need to raise failure from a try block in the solid? My assumption was that if a solid fails for any reason (including exception raise) that the failure hook would be called.

ah i see. yes, you would need to do

raise_on_error=False

on execute_pipeline

Oh my, thank you! So, in production should we do the same as to allow the failure_hook to be called?

no raise_on_error=true is only default and available to set when you are using the execute_pipeline api. the behavior through the system otherwise is raise_on_error false

Great, thanks so much, @yuhan!