https://dagster.io/ logo
#ask-community
Title
# ask-community
p

Pieter Custers

03/25/2022, 7:53 AM
Let me start with the notion that Dagster is amazing. The data world needs this! dagster spin That having said, I could use some advice: What is currently (0.14.5) the best way to pass env vars and (Kubernetes) secrets to jobs? It seems odd to me that the env vars and secrets that are set in the user code deployment are not passed on to the job pods. We have some awkward workarounds for this in place atm: • We set all secrets in
k8sRunLauncher.envSecrets
which means all these secrets will be set as env vars off the pods of every single job. Furthermore, if we add a secret we need to do a helm upgrade of the dagster deployment. Both are not desirable. • We set all env vars directly in the Docker container, but that means there is a different container depending on the environment you deploy to. Also not desirable.
plus1 5
Related issues on Git: env vars and secrets
d

daniel

03/25/2022, 3:06 PM
Hi Pieter - agree with you that this is one of the biggest rough edges with using dagster in production right now. We're actively working on having the right internal APIs to thread information from the user code deployment all the way through to the launched run pods (see https://github.com/dagster-io/dagster/pull/6925 for an example). Still a few weeks out I think, but hopefully will have more to share soon about better solutions that the awkward workarounds that you mentioned.
👍 1
p

Pieter Custers

03/25/2022, 3:57 PM
Great to hear you are working on this @daniel 🙏
d

daniel

03/30/2022, 4:31 PM
Just to follow up here, there's actually a PR out now that will let us close that issue out (just some details to sort out about backwards compatibility): https://github.com/dagster-io/dagster/pull/7236
p

Pieter Custers

04/13/2022, 12:40 PM
Great that this is so close to being deployed now!
condagster 1
Thanks for the update
Seems that 0.14.19 contains the feature, right? 😃 The PR you shared is still Open so I’m a bit confused
d

daniel

04/15/2022, 10:51 AM
That's right - I think it's likely to go out in the release next week
p

Pieter Custers

04/15/2022, 11:16 AM
🎉