if i make an alert policy with an empty tags section will it dagster #dagster-plus

if i make an alert policy with an empty tags secti...

Stephen Bailey

04/13/2022, 1:54 PM

if i make an alert policy with an empty tags section, will it send notifications for every run? a la

Copy code

alert_policies:
  - name: "slack-alert-policy"
    description: "An alert policy to send a Slack notification to sales on job failure or success."
    tags: []
    event_types:
      - "JOB_SUCCESS"
      - "JOB_FAILURE"
    notification_service:
      slack:
        slack_workspace_name: "hooli"
        slack_channel_name: "sales-notifications"

johann

04/13/2022, 1:56 PM

cc @rex

rex

04/13/2022, 2:04 PM

Currently, you’ll need to specify at least one tag for alerts to fire. But the behavior you're expecting is pretty reasonable, so I can make a change to make this into a reality

google fire blob 1

Stephen Bailey

04/13/2022, 2:07 PM

yeah, i think we'd probably go with an "alert the data team for everything" and then add supplementary policies for specific teams as a first use case

Stephen Bailey

04/15/2022, 1:00 PM

hey @rex, no pressure, but do you have an ETA on when something like this would go in? i'd prefer to run all slack alerts through this pattern rather than

on_run_failure

sensors, but it's easy enoguh for me to do so. we're rolling a bunch of stuff out in the next two weeks so just trying to sequence some work

Stephen Bailey

04/15/2022, 1:00 PM

no rush though

rex

04/15/2022, 1:00 PM

I have a PR out already, we can do another push today 🙂

dagsir 1

🤯 1

💥 1

5 Views

Open in Slack

Previous Next