We have to go through a lot of hoops right now to roll up our daily partitioned data into monthly partitioned data. Normally, we can just declare a downstream asset with the monthly partitioning and the default partition mapping will make it all happen. However, we have multiple datasets that are not continuously updated (they ended in the past). This means we have to use a

StaticPartitionsDefinition

and we can't do easy mapping. Instead we have to send it into an

op

through a

job

which has to emit the

AssetMaterializations

manually after also doing the I/O manually and then we also have to declare the downstream asset as a

SourceAsset

so we can properly feed it into the graph. All that is to say, what would be the lift to support

TimeWindowPartitionsDefinition

with an

end

? Either that, or figuring out a way to support custom mappings.

FYI - https://github.com/dagster-io/dagster/issues/11428

Hah, my coworker already commented on that issue. Thank you

It basically requires updating TimeWindowPartitionsDefinition to acknowledge the end date. We don't currently have the bandwidth to take this on, but I could review and provide tips if it's something you'd be able to submit a PR for?

Yes, I added to the existing ticket. We could look at this if we had some general guidance on what not to do.

I think a useful heuristic is that changes need to be made to everywhere inside

TimeWindowPartitionsDefinition

that's handling

self.end_offset

Sure, makes sense. We might dig into this maybe next week? Thanks